fix: More accurate type hints for Python @planning_entity #1272
Conversation
|
Thank you for your contribution, @luxaritas! We are a bit short-handed at the moment, with many people already taking their year-end holidays. I'm going to leave this one open until my colleague, who owns the Python part of the codebase, comes back in early January and does a code review. Please be patient - we have every intention to merge this PR. |
|
There was a problem hiding this comment.
LGTM, although the same change probably should be done for planning_solution (since that another decorator that has optional parameters); I can do that change myself. Unfortunately even with these changes, this won't do anything for PyCharm Intelisense (all lambda parameters are treated as Any in PyCharm in its custom type resolver; see this PyCharm issue for details).
|
Thank you for the contribution, @luxaritas! |
Resolves #1265