feat(accounts-db): change reference pointers to indexes #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xNineteen
commented
Nov 5, 2024
•
0xNineteen
commented
- new recycle_buffer struct to make direct indexing easier (recycle_fba doesnt fit what we need)
- integrate new recycle_buffer
- minimum integration of index write/read (snapshot validation passes using no pointers)
- min benchmarking 🧙
- index integration to rest of the methods (NOTE: decided not to remove the ptr approach because its pretty clean, and we can just store the index as extra data to support fast loading (not expensive))
- re-benchmark fully
- fuzzing (we dont actually need to re-fuzz here yet since reads still follow the ptr)
…rect index accesses and non-allocator interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.