#3761: Whitelist LoginPayloadResponse in UpstreamBridge#shouldHandle

Required for #3758 to function correctly.
SpigotMC · Jan 22, 2025 · 0aa2871 · 0aa2871
1 parent 1265a99
commit 0aa2871
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java b/proxy/src/main/java/net/md_5/bungee/connection/InitialHandler.java
@@ -704,6 +704,9 @@ public void handle(LoginPayloadResponse response) throws Exception
         }
         Preconditions.checkState( future != null, "Unexpected custom LoginPayloadResponse" );
         future.complete( response.getData() );
+
+        // we should never pass this to the backend
+        throw CancelSendSignal.INSTANCE;
     }
 
     @Override

diff --git a/proxy/src/main/java/net/md_5/bungee/connection/UpstreamBridge.java b/proxy/src/main/java/net/md_5/bungee/connection/UpstreamBridge.java
@@ -132,7 +132,7 @@ public void writabilityChanged(ChannelWrapper channel) throws Exception
     @Override
     public boolean shouldHandle(PacketWrapper packet) throws Exception
     {
-        return con.getServer() != null || packet.packet instanceof PluginMessage || packet.packet instanceof CookieResponse;
+        return con.getServer() != null || packet.packet instanceof PluginMessage || packet.packet instanceof CookieResponse || packet.packet instanceof LoginPayloadResponse;
     }
 
     @Override