Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SnowflakePowered/spirv-cross2-rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: SnowflakePowered/spirv-cross2-rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: complicated-sync
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 23 files changed
  • 1 contributor

Commits on Sep 5, 2024

  1. reflect: rename Scalar::width to Scalar::size

    @chyyran
    chyyran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5ed0f02 View commit details
    Browse the repository at this point in the history

  2. reflect(types): calculate the size hint from the type

    @chyyran
    chyyran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c92f3da View commit details
    Browse the repository at this point in the history

  3. constants: make sub_constants an iter to be consistent

    @chyyran
    chyyran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fa17441 View commit details
    Browse the repository at this point in the history

  4. spirv: use spirv crate for definitions in safe Rust 

    Gets rid of a lot of MaybeUninit needed
    @chyyran
    chyyran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5b619ca View commit details
    Browse the repository at this point in the history

  5. lib: clarify send + sync status

    @chyyran
    chyyran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a62a90e View commit details
    Browse the repository at this point in the history

  6. compile: rename ResourceBinding::PushConstant -> ResourceBinding::Pus… 

    …hConstantBuffer
    @chyyran
    chyyran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    33ebf12 View commit details
    Browse the repository at this point in the history

  7. lib: compiler is likely not Send. 

    While the SpirvCrossContext can be passed around,
if `Compiler` is send, then there can be unsynchronized access to the underlying spvc_context_s allocator.

`Compiler` can only be `Send` if there is only a single context ever attached to the compiler.
    @chyyran
    chyyran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4876737 View commit details
    Browse the repository at this point in the history

  8. types: remove declared_struct_size_with_runtime_array API 

    Use size_hint API instead
    @chyyran
    chyyran committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    94f1bbd View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. this doesnt sound right tbh

    @chyyran
    chyyran committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8684c9b View commit details
    Browse the repository at this point in the history
Loading