Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tag cleaning] Fix invalid function enum values in tags. #39

Open
Aerocatia opened this issue Nov 3, 2019 · 1 comment
Open

[Tag cleaning] Fix invalid function enum values in tags. #39

Aerocatia opened this issue Nov 3, 2019 · 1 comment
Labels
tag cleanup Some value in a tag needs to be fixed under these conditions

Comments

@Aerocatia
Copy link

It seems a few maps contain tags that have invalid values for the selected functions, likely caused by past HEK+ extraction. It just so happens these values don't cause the game to crash on Halo Custom Edition, but can crash other versions of the game. tool.exe does not check these either and will build the invalid tags into maps.

Here is an example; map [1] was used as a source for map [2], and in map [2] the tag characters/marine_armored/flashlight_marine.light became corrupted.

[1]http://maps.halonet.net/maps/beryl.zip
[2]http://maps.halonet.net/maps/Beryl_Rescue.zip
@ShellyHerself
Copy link
Member

ShellyHerself commented Jan 12, 2020 •
edited
Loading

Interesting. Yeah, that isn't particularly great. I'll talk with @MosesofEgypt about implementing a descriptor keyword option for fields that tells the enum_sanitizer to set out of bound values back to default.
Screenshot_20200112_232740

@ShellyHerself ShellyHerself transferred this issue from Sigmmma/refinery Jan 23, 2020
@ShellyHerself ShellyHerself added the tag cleanup Some value in a tag needs to be fixed under these conditions label Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag cleanup Some value in a tag needs to be fixed under these conditions
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aerocatia @ShellyHerself