Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting attributes to None before saving can leave explainers broken if saving fails #830

Open
jklaise opened this issue Dec 1, 2022 · 0 comments
Open

Setting attributes to None before saving can leave explainers broken if saving fails #830

jklaise opened this issue Dec 1, 2022 · 0 comments
Labels
Type: Bug Something isn't working

Comments

@jklaise
Copy link
Contributor

jklaise commented Dec 1, 2022

E.g.

alibi/alibi/saving.py

Line 111 in 91a2a88

explainer.predictor = None # type: ignore[attr-defined]
, if for some reason saving fails, the explainer is left without a predictor attribute and will not work anymore. We need to wrap saving in try/except and be careful to reset any changed attributes both on failure and success.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jklaise