Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requesting Volunteer Position to Overhaul Grammar #1706

Open
FruityGumGuiltyFruit opened this issue Oct 19, 2023 · 9 comments
Open

Requesting Volunteer Position to Overhaul Grammar #1706

FruityGumGuiltyFruit opened this issue Oct 19, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@FruityGumGuiltyFruit
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I would like to voluntarily work to improve Commander Wars by correcting grammar mistakes. In addition, I would like to write proper information for Intelligent Systems maps that lack it.

Describe the solution you'd like
I would work to fix as many grammatical errors as possible. This includes:

  • Typos
  • Syntax
  • Rewording CO abilities and powers to improve clarity
  • Add missing author and description information to Intelligent Systems maps

Additional context
If you do approve of this idea, how would you recommend I proceed?
@FruityGumGuiltyFruit FruityGumGuiltyFruit changed the title Requesting Volunteer Position to Overhall Requesting Volunteer Position to Overhaul Grammar Oct 19, 2023
@Robosturm
Copy link
Owner

  1. You would need Fork the repo.
  2. Next you need to get the setup described here: https://github.com/Robosturm/Commander_Wars/wiki/Translation-Support
  3. Translate the texts in the lang_en.ts to the improved / corrected version.
  4. Create a pull request

For CO's I would say: change the text in the js files of the co and make a merge request.
I would also recommend to add color high lighting e.g. the following text makes the some of the text be drawn in green.
"Cheapest unit. Can

capture
bases.
Vision +3
when on mountains."

As for maps open them in the map editor add the missing information save it and create a pull request.

@Robosturm Robosturm added the enhancement New feature or request label Oct 20, 2023
@FruityGumGuiltyFruit
Copy link
Contributor Author

Alright, thank you.

@FruityGumGuiltyFruit
Copy link
Contributor Author

I now have the time to begin work on this, so I will start.

@Rephath
Copy link
Contributor

Rephath commented Jan 8, 2024

@FruityGumGuiltyFruit Thank you for your kind work.

@FruityGumGuiltyFruit
Copy link
Contributor Author

I have had issues with getting QT to work correctly, so I am unsure how to proceed. What do you recommend I do?

@Robosturm
Copy link
Owner

What excatly doesn't work?
Should be pretty simple to setup on windows and I higly recommend against doing any editing without the qt-linquist tool.

@FruityGumGuiltyFruit
Copy link
Contributor Author

I don't know what to say for my issues with qt. If I knew what was wrong, I would be able to fix it. I will see what I can do to fix QT so I can do English translation fixes.

@FruityGumGuiltyFruit
Copy link
Contributor Author

I'm going to do further translation work. Do you have an estimate for when beta 38 will be released? I would like to know how much time I have to work.

@Robosturm
Copy link
Owner

Currently I'm not working on CoW so there's no release date at the moment.
I'm trying to push out a patch for the few current bugs though,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Rephath @Robosturm @FruityGumGuiltyFruit