Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of nqp::attrinited #747

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Eliminate use of nqp::attrinited #747

wants to merge 4 commits into from

Conversation

jnthn
Copy link
Contributor

@jnthn jnthn commented Nov 11, 2021

This is a follow-up to rakudo/rakudo#4633 that also removes the use of nqp::attrinited in NQP; it cannot be merged until the Rakudo PR has been merged. This does not do a rebootstrap, which would be the final step needed before MoarVM can drop support, as further changes to object representation configuration are also planned.

It seems we can get away with treating NQPMu as a sentinel for the sake
of default handling in NQP. This doesn't regress the NQP tests, nor the
Rakudo build/test/spectest, which should really exercise just about all
the things written in NQP.
@jnthn jnthn marked this pull request as draft November 11, 2021 15:40
@jnthn
Copy link
Contributor Author

jnthn commented Nov 11, 2021

Also, the tests ain't gonna pass before the Rakudo one is merged either.

@coke coke changed the base branch from master to main April 19, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant