Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curseforge/modrinth instance icons #3215

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix curseforge/modrinth instance icons #3215

wants to merge 1 commit into from

Conversation

Trial97
Copy link
Member

@Trial97 Trial97 commented Dec 16, 2024

Right now on develop if you create an instance through prism(curseforge/modrinth/atlauncher,...) the icon is not correctly applied
Introduce by #2800
Steps:

  • Add Instance
  • Select any provider(except custom and import)
  • Select and download an instance
  • Observe the instance icon(on dev is not present with this it should be present)

@Trial97
Fix curseforge/modrinth instance icons
f4d93a0 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
@Trial97 Trial97 added bug Something isn't working simple change changelog:omit A PR that doesn't appear in the changelog labels Dec 16, 2024
@Trial97 Trial97 added this to the 10.0 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TayouVR TayouVR TayouVR approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working changelog:omit A PR that doesn't appear in the changelog simple change
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Trial97 @TayouVR