Fix $INST_JAVA not being set for auto download java #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>
|
The auto install steps needs to be after loadmetadata so the data for what java should be downloaded to be available |
Signed-off-by: sshcrack <34072808+sshcrack@users.noreply.github.com>
Trial97
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Not tested it yet but this order should not break anything (maybe just the weird cases where users modify the instance settings or the components in the prelaunch command; e.g. maybe they have a tool that just changes the Minecraft version to the latest but that is already a long strech)
Ryex
approved these changes
Jan 8, 2025
getchoo
added
bug
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-9.x
git worktree add -d .worktree/backport-3179-to-release-9.x origin/release-9.x
cd .worktree/backport-3179-to-release-9.x
git switch --create backport-3179-to-release-9.x
git cherry-pick -x dedb7a2343f7d433492dee5930802ed47294b722 cf2dcbd431b0c4bb03ff527465f972d72f713b0c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3177