Skip to content

Commit

Permalink
Fix failing integration test due to notebook context menu (microsoft#…
Browse files Browse the repository at this point in the history
…5986)

- Updated test baselines
- Removed duplicate 'Standard SQL DB context menu test'
 -  it's identical to Azure test
 - Standalone database context menu test covers non-Azure
  • Loading branch information
kevcunnane authored Jun 11, 2019
1 parent 33a9f2e commit f1e38b6
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions extensions/integration-tests/src/objectExplorer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,19 @@ if (context.RunTest) {
test('BDC instance node label test', async function () {
await (new ObjectExplorerTester()).bdcNodeLabelTest();
});
test('Standard alone instance node label test', async function () {
test('Standalone instance node label test', async function () {
await (new ObjectExplorerTester()).standaloneNodeLabelTest();
});
test('Azure SQL DB instance node label test', async function () {
await (new ObjectExplorerTester()).sqlDbNodeLabelTest();
});
test('Standard SQL DB context menu test', async function () {
await (new ObjectExplorerTester()).sqlDbContextMenuTest();
});
test('BDC instance context menu test', async function () {
await (new ObjectExplorerTester()).bdcContextMenuTest();
});
test('Azure SQL DB context menu test', async function () {
await (new ObjectExplorerTester()).sqlDbContextMenuTest();
});
test('Stand alone database context menu test', async function () {
test('Standalone database context menu test', async function () {
await (new ObjectExplorerTester()).standAloneContextMenuTest();
});
});
Expand Down Expand Up @@ -67,14 +64,14 @@ class ObjectExplorerTester {

@stressify({ dop: ObjectExplorerTester.ParallelCount })
async sqlDbContextMenuTest(): Promise<void> {
let server = await getStandaloneServer();
let server = await getAzureServer();
let expectedActions: string[];
// Properties comes from the admin-tool-ext-win extension which is for Windows only, so the item won't show up on non-Win32 platforms
if (process.platform === 'win32') {
expectedActions = ['Manage', 'New Query', 'Disconnect', 'Delete Connection', 'Refresh', 'New Notebook', 'Data-tier Application wizard', 'Launch Profiler', 'Properties'];
expectedActions = ['Manage', 'New Query', 'New Notebook', 'Disconnect', 'Delete Connection', 'Refresh', 'Data-tier Application wizard', 'Launch Profiler', 'Properties'];
}
else {
expectedActions = ['Manage', 'New Query', 'Disconnect', 'Delete Connection', 'Refresh', 'New Notebook', 'Data-tier Application wizard', 'Launch Profiler'];
expectedActions = ['Manage', 'New Query', 'New Notebook', 'Disconnect', 'Delete Connection', 'Refresh', 'Data-tier Application wizard', 'Launch Profiler'];
}
await this.verifyContextMenu(server, expectedActions);
}
Expand All @@ -84,10 +81,10 @@ class ObjectExplorerTester {
let server = await getStandaloneServer();
let expectedActions: string[] = [];
if (process.platform === 'win32') {
expectedActions = ['Manage', 'New Query', 'Backup', 'Restore', 'Refresh', 'Data-tier Application wizard', 'Schema Compare', 'Import wizard', 'Generate Scripts...', 'Properties'];
expectedActions = ['Manage', 'New Query', 'New Notebook', 'Backup', 'Restore', 'Refresh', 'Data-tier Application wizard', 'Schema Compare', 'Import wizard', 'Generate Scripts...', 'Properties'];
}
else {
expectedActions = ['Manage', 'New Query', 'Backup', 'Restore', 'Refresh', 'Data-tier Application wizard', 'Schema Compare', 'Import wizard'];
expectedActions = ['Manage', 'New Query', 'New Notebook', 'Backup', 'Restore', 'Refresh', 'Data-tier Application wizard', 'Schema Compare', 'Import wizard'];
}
await this.verifyDBContextMenu(server, 3000, expectedActions);
}
Expand All @@ -98,10 +95,10 @@ class ObjectExplorerTester {
let expectedActions: string[];
// Properties comes from the admin-tool-ext-win extension which is for Windows only, so the item won't show up on non-Win32 platforms
if (process.platform === 'win32') {
expectedActions = ['Manage', 'New Query', 'Disconnect', 'Delete Connection', 'Refresh', 'New Notebook', 'Data-tier Application wizard', 'Launch Profiler', 'Properties'];
expectedActions = ['Manage', 'New Query', 'New Notebook', 'Disconnect', 'Delete Connection', 'Refresh', 'Data-tier Application wizard', 'Launch Profiler', 'Properties'];
}
else {
expectedActions = ['Manage', 'New Query', 'Disconnect', 'Delete Connection', 'Refresh', 'New Notebook', 'Data-tier Application wizard', 'Launch Profiler'];
expectedActions = ['Manage', 'New Query', 'New Notebook', 'Disconnect', 'Delete Connection', 'Refresh', 'Data-tier Application wizard', 'Launch Profiler'];
}
await this.verifyContextMenu(server, expectedActions);
}
Expand Down

0 comments on commit f1e38b6

Please sign in to comment.