Enabled zoom slider for notes widget #1608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emdek
requested changes
Nov 22, 2019
| @@ -50,9 +50,12 @@ class NotesContentsWidget final : public ContentsWidget | |||
| QIcon getIcon() const override; | |||
| ActionsManager::ActionDefinition::State getActionState(int identifier, const QVariantMap ¶meters = {}) const override; | |||
| bool eventFilter(QObject *object, QEvent *event) override; | |||
| virtual bool canZoom() const override; | |||
There was a problem hiding this comment.
There should be no virtual keyword here, and methods returning bool values should go after these returningint values.
| @@ -263,6 +266,20 @@ void NotesContentsWidget::triggerAction(int identifier, const QVariantMap ¶m | |||
| } | |||
| } | |||
|
|
|||
| void NotesContentsWidget::setZoom(int zoom) | |||
There was a problem hiding this comment.
I'm not sure if it is the best way to implement it, perhaps it could be achieved using QPlainTextEdit::zoomIn() and QPlainTextEdit::zoomOut(), but this API is kind of crappy. :-/
Anyway, I think that zooming should be implemented in TextEditWidget (adding getZoom() and setZoom()).
Also, using just point size might be risky, since AFAIR it can return 0, we might consider some method in Utils to apply zoom to fonts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature #1436