-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.6.x] Link to release instead of updating #3619
base: 0.6.x
Are you sure you want to change the base?
Conversation
Now that i re-think about, it https://github.com/OpenTabletDriver/OpenTabletDriver/releases/latest exists |
Use latest instead of targetting specific tag
5c0ccae
to
62cf2fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea of removing updater with a direct link is LGTM, but I also want to hear others opinions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but looking for opinions from others as well
Since this will rely entirely on the user manually updating, it would be a good idea to list the folder path where OTD is. Maybe a readonly textbox so the user can copy paste it. |
Might as well have a button that open the directory then. |
Using diff --git a/OpenTabletDriver.UX/Windows/Updater/UpdaterWindow.cs b/OpenTabletDriver.UX/Windows/Updater/UpdaterWindow.cs
index 4f08a153..fd94acc0 100644
--- a/OpenTabletDriver.UX/Windows/Updater/UpdaterWindow.cs
+++ b/OpenTabletDriver.UX/Windows/Updater/UpdaterWindow.cs
@@ -2,6 +2,7 @@ using System;
using System.Threading.Tasks;
using Eto.Drawing;
using Eto.Forms;
+using OpenTabletDriver.Desktop;
using OpenTabletDriver.Desktop.Interop;
using OpenTabletDriver.UX.Controls;
using OpenTabletDriver.UX.Controls.Generic;
@@ -49,9 +50,22 @@ namespace OpenTabletDriver.UX.Windows.Updater
new Bitmap(App.Logo.WithSize(256, 256)),
"An update is available to install",
$"OpenTabletDriver v{updateAvailable.Version}",
- new Button(OpenRelease)
+ new PaddingSpacerItem(),
+ new StackLayout()
{
- Text = "Go to Release"
+ Orientation = Orientation.Horizontal,
+ Items =
+ {
+ new Button(OpenRelease)
+ {
+ Text = "Go to Release"
+ },
+ new Button(OpenDirectory)
+ {
+ Text = "Open Directory"
+ }
+ },
+ Spacing = 5
},
new PaddingSpacerItem(),
}
@@ -70,5 +84,8 @@ namespace OpenTabletDriver.UX.Windows.Updater
private void OpenRelease(object sender, EventArgs e)
=> DesktopInterop.Open(LATEST_RELEASE_URL);
+
+ private void OpenDirectory(object sender, EventArgs e)
+ => DesktopInterop.Open(AppContext.BaseDirectory);
}
} |
Open the Github release instead of using the faulty updater for now.
One thing to note is that since no updater object is provided for Linux, they aren't notified of new updates.
That is, until they manually check for one via their Package Manager.
Closes #3618