Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.6.x] Fix AppInfo desync in UX #3615

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

Mrcubix
Copy link
Contributor

@Mrcubix Mrcubix commented Dec 18, 2024

Attempt at fixing the Plugin Manager & Preset Manager being instantiated with the wrong AppInfo.

Closes #3575

@Mrcubix
Copy link
Contributor Author

Mrcubix commented Dec 18, 2024

image

Well that's an odd way for unit tests to fail.
Someone prob need to re-run that one.

@Mrcubix
Copy link
Contributor Author

Mrcubix commented Dec 18, 2024

Might need to unload all plugins before re-instantiating the new manager.
Also could make the setters private & implement Refresh or something.

@gonX gonX added bug Something isn't working plugins Plugin or Plugin API related labels Dec 18, 2024
@gonX gonX added this to the 0.6.5.1 milestone Dec 18, 2024
@Mrcubix Mrcubix changed the title Fix AppInfo desync in UX [0.6.x] Fix AppInfo desync in UX Dec 19, 2024
Copy link
Member

@gonX gonX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

satisfy warnings (remove mainPanel definition in MainForm)

@Mrcubix Mrcubix requested a review from gonX December 22, 2024 17:32
@gonX gonX merged commit d9a4df0 into OpenTabletDriver:0.6.x Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugins Plugin or Plugin API related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants