Merge pull request OSGeo#11217 from rouault/header_pedantic

CI: check that all our public headers can be compiled with -Wall -Wpedantic
OSGeo-jp · Nov 7, 2024 · b89408a · b89408a
2 parents 48ddd5d + 8177ae3
commit b89408a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/autotest/postinstall/test_gdal-config.sh b/autotest/postinstall/test_gdal-config.sh
@@ -102,7 +102,7 @@ set -eu
 CXX="${CXX:-c++}"
 echo "Test that we can compile all headers with C++11 using ${CXX}"
 for i in $prefix/include/*.h; do
-  ${CXX} -std=c++11 -c $(${GDAL_CONFIG} --cflags) $i;
+  ${CXX} -Wall -Wpedantic -std=c++11 -c $(${GDAL_CONFIG} --cflags) $i;
 done
 
 echo "$ERRORS tests failed out of $NTESTS"

diff --git a/ogr/ogr_recordbatch.h b/ogr/ogr_recordbatch.h
@@ -19,7 +19,8 @@
 // https://github.com/apache/arrow/blob/main/cpp/src/arrow/c/abi.h WARNING: DO
 // NOT MODIFY the content as it would break interoperability !
 
-#pragma once
+#ifndef OGR_RECORDBATCH_H_INCLUDED
+#define OGR_RECORDBATCH_H_INCLUDED
 
 /*! @cond Doxygen_Suppress */
 
@@ -123,3 +124,5 @@ extern "C"
 #endif
 
 /*! @endcond */
+
+#endif  // OGR_RECORDBATCH_H_INCLUDED