Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'gdal raster edit' command to override SRS, extent and metadata #11487

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Dec 12, 2024

No description provided.

@rouault rouault added the funded through GSP Work funded through the GDAL Sponsorship Program label Dec 12, 2024
@OSGeo OSGeo deleted a comment from coveralls Dec 12, 2024
@rouault rouault merged commit bea5bc6 into OSGeo:master Dec 19, 2024
38 checks passed
@jratike80
Copy link
Collaborator

jratike80 commented Dec 19, 2024

Late comment, but how about having -a_bbox instead of -a_ullr? At least for me it is easier to remember the minx,miny,maxx,maxy order. But maybe it would not work, everything is not north-up.

@rouault
Copy link
Member Author

rouault commented Dec 19, 2024

Late comment, but how about having -a_bbox instead of -a_ullr

Are you refering to https://github.com/OSGeo/gdal/pull/11487/files#diff-9b7ac11ef53a8c359d463cb4baac1fdd36fb16cc84af402e505974e63d6451fcR198 ? If so, it is just that gdal edit is underneath redirecting to gdal_translate, and thus using its existing -a_ullr. An implementation detail.

the user has only access to gdal raster edit --extent=xmin,ymin,xmax,ymax , which will be rewritten to generate a north-up image. If we want to allow south-up image, then we'd probably need some explicit --south-up-geotransform or something like that?

@jratike80
Copy link
Collaborator

Are you refering to...

Yes, and I did not understand what I was reading. gdal raster edit --extent=xmin,ymin,xmax,ymax is fine. But well, we use bbox in some other places, is extent any better for this use case?

@rouault
Copy link
Member Author

rouault commented Dec 19, 2024

But well, we use bbox in some other places, is extent any better for this use case?

yes good observation. I was hesitating about that too. For some reason, I associated "bbox" with filtering use cases, hence an alternate name, but I'm not strongly minded about that, and I'm open to changes. Deciding about good new names is going to be a huge challenge... Perhaps you can create a ticket about that? I've added a "gdal_cli" issue label to categorize everything related to the new "gdal" frontend

@jratike80
Copy link
Collaborator

I just started to review the OGC standards but I fear I can find there contradicting examples. Usually that happens when comparing two or more standards.

@rouault
Copy link
Member Author

rouault commented Dec 19, 2024

I just started to review the OGC standards

oh noooooooooooooooo!!!!!!!!!!!!!!!! lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
funded through GSP Work funded through the GDAL Sponsorship Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants