clerk: fix reference to wrapped binary in wrapper #367117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the use of pushd/cd the reference to the wrapper binary was a relative path. This does not work in general as it is depending on the working directory where the wrapper is executed.
github-actions
bot
added
10.rebuild-darwin: 0
|
Ping for maintainers @anderspapitto and @wineee. Building before and after this change and running diff -r old/bin/clerk new/bin/clerk
39c39
< exec -a "$0" "./.clerk-wrapped" "$@"
---
> exec -a "$0" "/nix/store/mfv9g2lbpiz20yzfpnk8x9yxfpv6j4kw-clerk-0-unstable-2024-02-20/bin/.clerk-wrapped" "$@"
diff -r old/bin/clerk_rating_client new/bin/clerk_rating_client
39c39
< exec -a "$0" "./.clerk_rating_client-wrapped" "$@"
---
> exec -a "$0" "/nix/store/mfv9g2lbpiz20yzfpnk8x9yxfpv6j4kw-clerk-0-unstable-2024-02-20/bin/.clerk_rating_client-wrapped" "$@"
diff -r old/lib/systemd/user/clerk_rating_client.service new/lib/systemd/user/clerk_rating_client.service
7c7
< ExecStart=/nix/store/08daa6vf6wmhl2sdcav3cjlkbcanip0m-clerk-0-unstable-2024-02-20/bin/clerk_rating_client
---
> ExecStart=/nix/store/mfv9g2lbpiz20yzfpnk8x9yxfpv6j4kw-clerk-0-unstable-2024-02-20/bin/clerk_rating_client
diff -r old/share/systemd/user/clerk_rating_client.service new/share/systemd/user/clerk_rating_client.service
7c7
< ExecStart=/nix/store/08daa6vf6wmhl2sdcav3cjlkbcanip0m-clerk-0-unstable-2024-02-20/bin/clerk_rating_client
---
> ExecStart=/nix/store/mfv9g2lbpiz20yzfpnk8x9yxfpv6j4kw-clerk-0-unstable-2024-02-20/bin/clerk_rating_client |
|
I guess this was introduced in b1b1176. Did it work for anybody since then? Or did the behaviour of wrapProgram change? |
wineee
approved these changes
Dec 22, 2024
|
Thanks, are you interested in adding yourself as a maintainer? I haven't used clerk for a long time |
|
I am also not using clerk, I wanted to try it out and found this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the use of pushd/cd the reference to the wrapper binary was a relative path. This does not work in general as it is depending on the working directory where the wrapper is executed.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.