Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport staging-24.11] envision: autopatchelf after build #365640

Open
wants to merge 3 commits into
base: staging-24.11
Choose a base branch
from

Conversation

Pandapip1
Copy link
Contributor

Backports #359156

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Dec 16, 2024
@Pandapip1 Pandapip1 requested a review from Scrumplex December 16, 2024 15:59
@nix-owners nix-owners bot requested a review from layus December 16, 2024 16:00
@Pandapip1 Pandapip1 added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 16, 2024
@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Dec 16, 2024

Not sure why the cherry-pick action is failing; I did have to manually resolve a merge conflict (maybe that's the issue?).

@Pandapip1
Copy link
Contributor Author

Hey, any chance this can be merged?

@Scrumplex
Copy link
Member

Scrumplex commented Dec 29, 2024

I tried to rebase this onto staging-next, but it conflicts currently for the last commit (envision)

@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Dec 29, 2024

That's fine; let's just get this merged into 24.11 staging.

@mweinelt
Copy link
Member

Not sure why the cherry-pick action is failing; I did have to manually resolve a merge conflict (maybe that's the issue?).

That action shows diffs to the supposedly cherry-picked commit and is there to prevent code injection in a backport.

@Pandapip1
Copy link
Contributor Author

That action shows diffs to the supposedly cherry-picked commit and is there to prevent code injection in a backport.

I know, but I did cherry-pick the commits. You can see that from the commit descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants