Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-spy: 0.3.14-unstable-2024-02-27 -> 0.4.0 #355161

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

apeschar
Copy link
Contributor

@apeschar apeschar commented Nov 11, 2024

https://github.com/benfred/py-spy/releases/tag/v0.4.0
benfred/py-spy@8dd5492...593d6d8

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 16, 2024
@LunNova
Copy link
Member

LunNova commented Dec 20, 2024

Is this backportable? Previous version is an unstable hash and isn't compatible with the default python 3 interpreter in 24.11.

@LunNova
Copy link
Member

LunNova commented Dec 20, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 355161


x86_64-linux

⏩ 4 packages marked as broken and skipped:
  • python311Packages.vllm
  • python311Packages.vllm.dist
  • python312Packages.vllm
  • python312Packages.vllm.dist
✅ 9 packages built:
  • py-spy
  • python311Packages.kserve
  • python311Packages.kserve.dist
  • python311Packages.ray
  • python311Packages.ray.dist
  • python312Packages.kserve
  • python312Packages.kserve.dist
  • python312Packages.ray
  • python312Packages.ray.dist

@LunNova LunNova added the backport release-24.11 Backport PR automatically label Dec 20, 2024
@LunNova
Copy link
Member

LunNova commented Dec 20, 2024

Very few rebuilds and makes the package usable, think it should be fine to backport so added the label.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2159


src = fetchFromGitHub {
owner = "benfred";
repo = "py-spy";
rev = "8dd54929106916a3c961cc57c1172793ce126180";
hash = "sha256-rrngOqlXIJXbh3A7OBEcgoakZyyuvlHHXhWo3/1BRpY=";
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${version}";
tag = "v${version}";

@SuperSandro2000 SuperSandro2000 merged commit 9212245 into NixOS:master Dec 23, 2024
30 checks passed
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Dec 23, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants