Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains-runner: init at 3.0.4 #348382

Merged
merged 1 commit into from
Dec 23, 2024
Merged

jetbrains-runner: init at 3.0.4 #348382

merged 1 commit into from
Dec 23, 2024

Conversation

js6pak
Copy link
Contributor

@js6pak js6pak commented Oct 13, 2024

https://github.com/alex1701c/JetBrainsRunner

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 13, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 14, 2024
@HeitorAugustoLN
Copy link
Member

Result of nixpkgs-review pr 348382 run on x86_64-linux 1

1 package built:
  • jetbrains-runner

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 19, 2024
FliegendeWurst
FliegendeWurst approved these changes Dec 5, 2024
View reviewed changes
pkgs/by-name/je/jetbrains-runner/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/je/jetbrains-runner/package.nix Outdated Show resolved Hide resolved
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 5, 2024
@js6pak js6pak force-pushed the jetbrains-runner/init branch from e0b91ec to 5c10c26 Compare December 23, 2024 03:07
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 23, 2024
@FliegendeWurst FliegendeWurst merged commit f6cb128 into NixOS:master Dec 23, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeitorAugustoLN HeitorAugustoLN HeitorAugustoLN approved these changes

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@js6pak @HeitorAugustoLN @FliegendeWurst @wegank