Adding time grid widget #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…t' into add_time_grid_widget
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 66.22% 65.48% -0.74%
==========================================
Files 35 36 +1
Lines 3458 3607 +149
==========================================
+ Hits 2290 2362 +72
- Misses 1168 1245 +77
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have a quick visual representation of how the timing of the objects stands in regard to each other. I put this together quickly, so I'm very open to stylistic and other suggestions. I tested this against the Valero Conversion from the Buzsaki lab, and also used another dataset using Panel.
I'm also uncertain about the best placement for this, so right now it sits between the header data and the accordion. I'm not clear on how it could be in the accordion as this maps directo to the nwbfile and not to a sub-type...
This does not have a lot of functionality - and I think it probably should not - but I added the possibility of having epoch guides for orientation. I also thought that it might be a good idea to have an option to mark the trials, but I was concerned that this would be more computationally costly and I didn't have a lot of time to put this together.
This is using panel:
And this is using a local example with more structure:
output.mov