Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new benchmarking platform #16

Closed
yarikoptic opened this issue Jan 27, 2024 · 6 comments
Closed

A new benchmarking platform #16

yarikoptic opened this issue Jan 27, 2024 · 6 comments

Comments

@yarikoptic
Copy link

We do use asv too but recently discovered

An interesting new benchmarking CI/portal: https://codspeed.io/ which seems to be really easy to use - https://docs.codspeed.io/benchmarks/python - just pytest mark some unittests to be your benchmarks. it is all based on https://pypi.org/project/pytest-benchmark/ so - quite available locally.

So might be worth considering IMHO and do research first

@oruebel
Copy link
Contributor

oruebel commented Jan 27, 2024

Thanks @yarikoptic we'll take a look! Currently we are targeting mainly benchmarks for cloud access and some of the tests may have fairly long runtimes (at least compared to standard unit test). At first glance, I think codspeed.io may be more appropriate for benchmarks based on our existing unit tests in PyNWB. I think that would be useful too, but that would target a different use case (i.e., local performance and smaller/faster tests)

@yarikoptic
Copy link
Author

For "cloud access", potentially very relevant is dandi/dandisets-healthstatus#66 where @jwodder is about to review a number of FUSE solutions on top of our https://github.com/dandi/dandi-webdav/ and also compare to datalad-fuse solution we use so far for dandisets-healthstatus.

@oruebel
Copy link
Contributor

oruebel commented Jan 29, 2024

Thanks! Currently we are planning to test data streaming with HDF5:

  • ros3 via h5py
  • fsspec
  • remfile
  • kerchunk

We are also planning to compare with Zarr.

@jwodder @yarikoptic if there are other options you think we should include in our benchmark, then please just ping us. Generally, we are looking at options for streaming that allow access to subsets of an NWB file in HDF5 or Zarr without having to download the whole file.

@yarikoptic
Copy link
Author

ideally, if up to it, would be great also to see benchmarking of setups with local caching where on first run the solution (like fsspec) establishes local cache, and then on subsequent rerun uses local content (likely first checking ETag on remote URL to remain the same)... but might be something to really keep for future investigations ;-)

@oruebel
Copy link
Contributor

oruebel commented Apr 24, 2024

ideally, if up to it, would be great also to see benchmarking of setups with local caching

We are currently adding fsspec + disk cache and remfile + disk cache test. The current tests clean up the cache between runs, so we only see the impact of the cache within the context of the specific operation. It may be interesting to also add tests where we run the test case first in the setup to prime the cache and then evaluate how long it takes to repeat the same operation after the cache has been set up. I'll make a separate issue for this so we can discuss there.

@oruebel
Copy link
Contributor

oruebel commented Apr 24, 2024

I created #46 for the tests with caching. I'll close this issue for now, but please reopen if I missed anything or you have additional comments.

@oruebel oruebel closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants