Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RandomState with Generator #173

Merged
merged 16 commits into from
Oct 21, 2024
Merged

Replace RandomState with Generator #173

merged 16 commits into from
Oct 21, 2024

Conversation

leonlan
Copy link
Collaborator

@leonlan leonlan commented Sep 12, 2024

This PR:

Notes:

  • It is essential that you add a test when making code changes.
    This keeps the code coverage level up, and helps ensure the changes work as intended.
  • When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
  • Docstring additions must render correctly, including escapes and LaTeX.

@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (909e09f) to head (4f1d300).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   99.46%   99.46%   -0.01%     
==========================================
  Files          30       30              
  Lines         748      745       -3     
==========================================
- Hits          744      741       -3     
  Misses          4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leonlan leonlan marked this pull request as ready for review October 21, 2024 10:06
@leonlan leonlan requested a review from N-Wouda October 21, 2024 10:07
N-Wouda
N-Wouda approved these changes Oct 21, 2024
View reviewed changes
Copy link
Owner

@N-Wouda N-Wouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; few minor things

alns/accept/AcceptanceCriterion.py Show resolved Hide resolved
alns/tests/test_result.py Outdated Show resolved Hide resolved
@leonlan leonlan merged commit a3631f1 into master Oct 21, 2024
8 checks passed
@leonlan leonlan deleted the replace-rng branch October 21, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-Wouda N-Wouda N-Wouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace RandomState with Generator
2 participants
@leonlan @N-Wouda