Add SDL mapping for Key 35 (102 key backslash or UK pound key) #7945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Less reliance needs to be made on SDL key mappings. They are not cross platform and skip many non-US keys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7488
Adding this key entry as Oem8 due to lack of suitable existing mappings in the Oem keys and I wasn't sure it was right to necessarily add a new one for this use case.
The UK keyboard #/~ key maps as key code 35 in SDL due to its internal conversion to ascii, however there is no OEM Pound virtual key, and in native UK keyboard mappings this key maps to OEM 7 (which is OEM Quote in mono's mappings).
By Mapping this key to Oem8 we can allow support for this key in DesktopGL for 102 key users, however it may need to be checked/verified with someone that has a US 102 key layout keyboard to ensure the mapping comes through correctly.