6298 Error in BoundingBox.Contains(BoundingFrustum) #7444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initram
reviewed
Jan 24, 2021
|
Have you considered this edge case? I would think that should result in intersect. Here no corner is inside the volume of the other shape, so just checking corners are not enough to handle all intersection cases. |
|
This needs a test case for us to merge @Tauroctonos . If you or someone adds one we can merge it. |
|
@Tauroctonos are you able to provide the Unit test to accompany this PR, or should it be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed logical error in frustum containment method; see #6298