Return prioritization 3rd try #1812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling &return triggers a stack unwind which can cause code (e.g. in `LEAVE` phasers) to run. That code can also call `&return`. The returns conflict, if the later return unwinds over the return continuation marker of the former return in the call stack, i.e. the `LEAVE` frame. In such situations one wants the return to win that unwinds more of the stack. This is the behavior implemented by this change. Previously the later return always won. This implements the behavior discussed in Raku/problem-solving#417.
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
&returntriggers a stack unwind which can cause code (e.g. inLEAVEphasers) to run. That code can also call&return. The returnsconflict, if the later return unwinds over the return continuation
marker of the former return in the call stack, i.e. the
LEAVEframe.In such situations one wants the return to win that unwinds more of the
stack. This is the behavior implemented by this change. Previously the
later return always won.
This implements the behavior discussed in Raku/problem-solving#417.