Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragonhyeon: changed fixed z noise map implementation details #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dragonHyeon
Copy link

@dragonHyeon dragonHyeon commented May 26, 2023

Hello. Thank you for your contribution. Your code helped me a lot understanding SinGAN. I've changed part of your code.

I think using z_rec as a fixed_Zs[0] (which denoted as z* in paper) might be a better choice rather than just normal z. Also it seems more reasonable to use zero tensors as fixed_Zs[1:] rather than normal z since they use 0 as fixed noise in paper. (though there's no problem running your code since they have been just used to purpose of getting the shape of tensors.)

If you think it's reasonable I hope you merge my code. Once again, thanks for your readable, scalable code!

@dragonHyeon dragonHyeon mentioned this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant