Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to animation #3457

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add type hints to animation #3457

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1ad84bf
Add type hints to `_config`
Viicos Sep 26, 2023
3d6920d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 4, 2023
38a6f8b
Fix call issues
Viicos Nov 4, 2023
f8cd0e3
Fix wrong value being used
Viicos Nov 5, 2023
8760e53
Add type hints to `animation`
Viicos Nov 16, 2023
5d09b5c
Merge branch 'main' into typing-animation
Viicos Jan 13, 2024
c40b950
More work
Viicos Jan 13, 2024
c31337e
Merge branch 'main' into typing-animation
Viicos Feb 13, 2024
e3d9a84
Fix import
Viicos Feb 13, 2024
17efceb
Add mypy to dependencies
Viicos Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix call issues
  • Loading branch information
@Viicos
Viicos committed Nov 4, 2023
commit 38a6f8b5b78a5c98067935a5f4ef70514869805e
6 changes: 3 additions & 3 deletions manim/_config/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,7 @@ def pixel_width(self) -> int:

@pixel_width.setter
def pixel_width(self, value: int) -> None:
self._set_pos_number("pixel_width", value)
self._set_pos_number("pixel_width", value, False)

@property
def pixel_height(self) -> int:
Expand All @@ -1097,7 +1097,7 @@ def pixel_height(self) -> int:

@pixel_height.setter
def pixel_height(self, value: int) -> None:
self._set_pos_number("pixel_height", value)
self._set_pos_number("pixel_height", value, False)

@property
def aspect_ratio(self) -> int:
Expand Down Expand Up @@ -1226,7 +1226,7 @@ def flush_cache(self) -> bool:

@flush_cache.setter
def flush_cache(self, value: bool) -> None:
self._set_boolean("flush_cache", value, True)
self._set_boolean("flush_cache", value)

@property
def disable_caching(self) -> bool:
Expand Down