Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add rknpu version 0.9.8 #1093

Open
vincenzodentamaro opened this issue Oct 17, 2024 · 5 comments
Open

Feature Request: Add rknpu version 0.9.8 #1093

vincenzodentamaro opened this issue Oct 17, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@vincenzodentamaro
Copy link

vincenzodentamaro commented Oct 17, 2024 •
edited
Loading

Feature Description

As per the title, please add the new RKNPU kernel version 0.9.8 contained here https://github.com/airockchip/rknn-llm/tree/main/rknpu-driver

In the documentation, rockchip says that if the build fails modify the kernel header file kernel/include/linux/mm.h by adding the following code:


static inline void vm_flags_set(struct vm_area_struct *vma, vm_flags_t flags){ 
vma->vm_flags |= flags; 
} 
static inline void vm_flags_clear(struct vm_area_struct *vma, vm_flags_t flags){ 
vma->vm_flags &= ~flags; 
}

please update the releases with such kernel driver ASAP. If possible compile it as external module to be loaded with modprobe so if they update the driver, we can recompile it and load it with modprobe instead of recompiling the kernel.

Thank you
@vincenzodentamaro vincenzodentamaro added the enhancement New feature or request label Oct 17, 2024
@Joshua-Riek
Copy link
Owner

I do not have time, can you open a pull request?

@vincenzodentamaro
Copy link
Author

Yes of course, I will modify the kernel and do a pull request.
Thank you for answering

@darkice9x
Copy link

darkice9x commented Oct 23, 2024 •
edited
Loading

vm_flags_set and vm_flags_clear have already been added to ./linux-rockchip/include/linux/version_compat_defs.h.
When adding rknpu 0.9.8, there are functions that were not implemented, but they are not needed when using rk3588, so just comment them out.

To comment out the specific line in linux-rockchip/drivers/rknpu/rknpu_devfreq.c at line #237 .set_soc_info = rockchip_opp_set_low_length,.

@SimplyCorbett
Copy link

Did you open the pull request? Thanks!

@c0zaut
Copy link

c0zaut commented Nov 2, 2024

@SimplyCorbett - it was submitted via the kernel repo: Joshua-Riek/linux-rockchip#36

@Joshua-Riek Joshua-Riek removed their assignment Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@darkice9x @vincenzodentamaro @SimplyCorbett @Joshua-Riek @c0zaut