Auto Scroll to Bottom On Keyboard Reveal #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnystrom
requested changes
Sep 22, 2018
| @@ -86,6 +86,7 @@ open class MessageViewController: UIViewController, MessageAutocompleteControlle | |||
| internal var scrollView: UIScrollView? | |||
| internal var keyboardHeight: CGFloat = 0 | |||
| internal var isMessageViewHidden = false | |||
| internal var scrollsToBottomOnKeyboardReveal = true | |||
There was a problem hiding this comment.
Can this default be false since it'd change behavior w/out warning to anyone that upgrades?
|
@rnystrom default now false :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Request
Scroll to the bottom of the scroll view when the keyboard is revealed (e.g. the Messages app)
Implementation
Add an instance variable to
MessageViewController-scrollsToBottomOnKeyboardReveal, check if value is set insidekeyboardWillShowblock, and scroll to bottom of scroll view if true. Default is set to true.