fix: wrap logging buffer writes in critical section in Windows logging implementation #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * reading from the buffer). */ | ||
| xCurrentTask = GetCurrentThread(); | ||
| iOriginalPriority = GetThreadPriority( xCurrentTask ); | ||
| SetThreadPriority( GetCurrentThread(), THREAD_PRIORITY_TIME_CRITICAL ); |
There was a problem hiding this comment.
A naive question: Why wasn't this able to achieve the same thing as taskENTER_CRITICAL()?
kar-rahul-aws
previously approved these changes
Jul 20, 2023
ActoryOu
previously approved these changes
Jul 20, 2023
|
/bot run formatting |
github-actions
bot
dismissed stale reviews from kar-rahul-aws and ActoryOu
via
49e66ea
|
@ydhuang28 I think |
every-breaking-wave
pushed a commit
to every-breaking-wave/FreeRTOS
that referenced
this pull request
Nov 15, 2024
* Adding SMP coverity example * Add coverity scan flow * Fix format * Update README.md * Code review suggestions Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> --------- Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-34-245.ap-northeast-1.compute.internal> Co-authored-by: Gaurav-Aggarwal-AWS <33462878+aggarg@users.noreply.github.com> Co-authored-by: Gaurav Aggarwal <aggarg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap logging buffer writes in critical section in Windows logging implementation
Description
WinSim (by virtue of Windows behavior) does not change task priority correctly/immediately. previously the logging buffer writes were protected by raising and lower task priority, which doesn't protect the buffer properly. This fix addresses that.
Test Steps
n/a
Checklist:
Related Issue
n/a
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.