Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Rembench obsolete since it causes crash #247

Open
iplayfast opened this issue Jan 14, 2023 · 6 comments
Open

Make Rembench obsolete since it causes crash #247

iplayfast opened this issue Jan 14, 2023 · 6 comments
Labels
deprecate workbenches that should be deprecated New WB/Addon 📦 New contribution to the Addon repo

Comments

@iplayfast
Copy link

The RemBench addon is apparently messing up the menu system in FreeCad (File and View menus can't be clicked on).
After figuring out that it was the RemBench that was responsible, I realized that it is actually obsolete. It's purpose was to trace the different workbenches as you moved across different tabs.
FreeCad does this without the workbench installed, so I propose removing it from the add on list, and possibly adding a popup warning for people who have it installed.
@iplayfast iplayfast added the New WB/Addon 📦 New contribution to the Addon repo label Jan 14, 2023
@luzpaz
Copy link
Collaborator

luzpaz commented Jan 14, 2023

Please link to original ticket this was found in. TIA!

@luzpaz
Copy link
Collaborator

luzpaz commented Jan 15, 2023

Original issue: FreeCAD/FreeCAD#7965

@luzpaz luzpaz changed the title Remove Old Workbench. Make Rembench obsolete since it causes crash Jan 15, 2023
@luzpaz luzpaz mentioned this issue Jan 15, 2023
Open
@chennes
Copy link
Member

chennes commented Jan 15, 2023

I have marked it obsolete as of 0.20 -- should that be 0.21 instead? Note that right now the AM doesn't actively prompt for uninstallation, this feature just prevents it from being installed new.

@luzpaz
Copy link
Collaborator

luzpaz commented Jan 16, 2023

@iplayfast ☝️

@iplayfast
Copy link
Author

This problem occurred around Thu Jun 16 09:03:24 2022 +0200. I'm not sure of the version number at that time. 0.20 is probably safest.

@Syres916
Copy link

Syres916 commented Feb 1, 2023 •
edited
Loading

Surely the root cause is any Addon that specifically appends a menu after Help, both PieMenu and Rembench do this (Accessories) and both give the same symptoms, so is there an alternative method for creating the menu in Python that doesn't cause the symptoms or find out why the core code has started this regression??

All testing done with:

OS: Linux Mint 20.3 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.21.0.31737 (Git)
Build type: Release
Branch: master
Hash: 2e5cb03261269ea2498a6062e4e949ccdc32fcc6
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.3.0
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * ThreadProfile 1.84.0
  * A2plus 0.4.60i
  * freecad.gears 1.0.0
  * Assembly3 0.11.4
  * Curves 0.6.5
  * Plot 2022.4.17
  * fasteners 0.4.54
  * sheetmetal 0.2.59

@luzpaz luzpaz added the deprecate workbenches that should be deprecated label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecate workbenches that should be deprecated New WB/Addon 📦 New contribution to the Addon repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chennes @iplayfast @luzpaz @Syres916