Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dev Module #4087

Open
wants to merge 19 commits into
base: 1.21.1
Choose a base branch
from
Open

Add Dev Module #4087

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
eb2966e
Add dev module
IThundxr Sep 11, 2024
f21777c
remove dependency
IThundxr Sep 11, 2024
5e80e69
run formatter
IThundxr Sep 12, 2024
09ac8f6
make checkstyle happy?
IThundxr Sep 12, 2024
902e83e
First set of review fixes
IThundxr Sep 13, 2024
5c36c73
Remove unused import
IThundxr Sep 13, 2024
e5226ed
fix typo
IThundxr Sep 13, 2024
a5bd1d0
Address the last few reviews
IThundxr Sep 13, 2024
4a921f5
Last fixes
IThundxr Sep 13, 2024
95fe8c7
run formatter
IThundxr Sep 13, 2024
ae86e82
update getProperty
IThundxr Sep 14, 2024
1594f91
fix npe
IThundxr Sep 14, 2024
8752541
Address reviews
IThundxr Sep 24, 2024
7347b52
run spotless
IThundxr Sep 24, 2024
3f59370
make spotless happy
IThundxr Sep 25, 2024
effa8c3
fix name
IThundxr Sep 25, 2024
7a9c684
fix package name
IThundxr Sep 26, 2024
0a3f573
Merge branch '1.21.1' into dev-module
IThundxr Nov 15, 2024
723714a
Update javadocs
IThundxr Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update getProperty
  • Loading branch information
@IThundxr
IThundxr committed Sep 14, 2024
commit ae86e8227593df98db9ba5f10219806f30f679c5
7 changes: 3 additions & 4 deletions fabric-api-dev/src/main/java/net/fabricmc/fabric/impl/FabricDevProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,9 @@ public class FabricDevProperties {
private static final boolean IS_DEVELOPMENT_ENV = FabricLoader.getInstance().isDevelopmentEnvironment();

private static boolean getProperty(String name, boolean defaultValue) {
IThundxr marked this conversation as resolved.
Show resolved Hide resolved
try {
return "true".equalsIgnoreCase(System.getProperty("fabric.dev" + name));
} catch (Throwable e) {
String propertyValue = System.getProperty("fabric.dev" + name);
IThundxr marked this conversation as resolved.
Show resolved Hide resolved
if (propertyValue.isEmpty())
return IS_DEVELOPMENT_ENV && defaultValue;
}
return "true".equalsIgnoreCase(propertyValue);
}
}