Add Dev Module #4087
Open
Add Dev Module #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
requested changes
Sep 13, 2024
fabric-api-dev/src/main/java/net/fabricmc/fabric/FabricDev.java
Outdated
Show resolved
Hide resolved
fabric-api-dev/src/main/java/net/fabricmc/fabric/FabricDev.java
Outdated
Show resolved
Hide resolved
fabric-api-dev/src/main/java/net/fabricmc/fabric/mixin/dev/ArgumentTypesMixin.java
Outdated
Show resolved
Hide resolved
fabric-api-dev/src/main/java/net/fabricmc/fabric/mixin/dev/ArgumentTypesMixin.java
Outdated
Show resolved
Hide resolved
apple502j
suggested changes
Sep 13, 2024
fabric-api-dev/src/main/java/net/fabricmc/fabric/FabricDev.java
Outdated
Show resolved
Hide resolved
modmuss50
requested changes
Sep 24, 2024
fabric-api-dev/src/main/java/net/fabricmc/fabric/impl/FabricDevProperties.java
Outdated
Show resolved
Hide resolved
fabric-api-dev/src/main/java/net/fabricmc/fabric/mixin/dev/BlockAndItemMixin.java
Outdated
Show resolved
Hide resolved
fabric-api-dev/src/main/java/net/fabricmc/fabric/impl/FabricDevProperties.java
Outdated
Show resolved
Hide resolved
fabric-api-dev/src/main/java/net/fabricmc/fabric/impl/FabricDevProperties.java
Outdated
Show resolved
Hide resolved
fabric-api-dev/src/main/java/net/fabricmc/fabric/impl/FabricDevProperties.java
Outdated
Show resolved
Hide resolved
| @@ -14,6 +14,7 @@ include 'fabric-api-bom' | |||
| include 'fabric-api-catalog' | |||
|
|
|||
| include 'fabric-api-base' | |||
| include 'fabric-api-dev' | |||
There was a problem hiding this comment.
This should be set as a dev only module, and not included in the prod jar.
There was a problem hiding this comment.
The reason it's included in prod is since some developers requested that they would be able to use it outside of dev envs to be debugging in prod easier
fabric-api-dev/src/main/java/net/fabricmc/fabric/impl/FabricDevProperties.java
Outdated
Show resolved
Hide resolved
fabric-api-dev/src/main/java/net/fabricmc/fabric/impl/FabricDevProperties.java
Outdated
Show resolved
Hide resolved
| * Default value: true</br> | ||
| * {@link CommandManager#execute(ParseResults, String)} | ||
| */ | ||
| public static final boolean ENABLE_COMMAND_EXCEPTION_LOGGING = getProperty("enableCommandExceptionLogging", true); |
There was a problem hiding this comment.
I wonder if these should be named such as fabric.dev.command.logging.exception (with all of the others following the same pattern?
fabric-api-dev/src/main/java/net/fabricmc/fabric/api/dev/v1/FabricDevProperties.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds properties for enabling certain things controlled by SharedConstants.isDevelopment so developers can pick and choose what they want to enable instead of everything being enabled