Make notification checkbox label clickable

Fix brave#1590 Auditors: @bbondy
EdikKing · May 6, 2016 · 3fb907a · 3fb907a
1 parent 571d781
commit 3fb907a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/js/components/notificationBar.js b/js/components/notificationBar.js
@@ -18,6 +18,10 @@ class NotificationItem extends ImmutableComponent {
     ipc.emit(messages.SHORTCUT_NEW_FRAME, {}, this.props.detail.get('options').get('advancedLink'))
   }
 
+  toggleCheckbox () {
+    this.checkbox.checked = !this.checkbox.checked
+  }
+
   render () {
     let i = 0
     const options = this.props.detail.get('options')
@@ -33,7 +37,10 @@ class NotificationItem extends ImmutableComponent {
       <span className='notificationOptions'>
         {
           options.get('persist')
-            ? <span><input type='checkbox' ref={(node) => { this.checkbox = node }} /><label data-l10n-id='rememberDecision' /></span>
+            ? <span>
+              <input type='checkbox' ref={(node) => { this.checkbox = node }} />
+              <label data-l10n-id='rememberDecision' onClick={this.toggleCheckbox.bind(this)} />
+            </span>
             : null
         }
         {

diff --git a/less/notificationBar.less b/less/notificationBar.less
@@ -40,6 +40,7 @@
     font-size: 15px;
     padding: 0 10px 0 0;
     color: #666;
+    cursor: pointer;
   }
   input[type="checkbox"] {
     margin: 0 3px;