Skip to content

Commit

Permalink
Remove unnecessary js files. (oppia#3057)
Browse files Browse the repository at this point in the history 
* the first phase of making about page light

* removed exploration summary tile from base to specific pages that require it.

* address reviewers comments

* added loading-dots directive to library and collection editor pages
  • Loading branch information
@makoscafee @seanlip
makoscafee authored and seanlip committed Feb 16, 2017
1 parent 399fcb8 commit 0b155cb
Show file tree
Hide file tree
Showing 8 changed files with 59 additions and 24 deletions.
23 changes: 0 additions & 23 deletions core/templates/dev/head/pages/base.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -249,37 +249,14 @@ <h2>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/ImageUploaderDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/ObjectEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/Select2DropdownDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedBoolEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedChoicesEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedCustomEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedDictEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedExpressionEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedFloatEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedHtmlEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedIntEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedListEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedUnicodeEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedCustomViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedDictViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedHtmlViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedListViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedPrimitiveViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedUnicodeViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedViewerDirective.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/loading/LoadingDotsDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/side_navigation_bar/SideNavigationBarDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/social_buttons/SocialButtonsDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/top_navigation_bar/TopNavigationBarDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/summary_tile/CircularImageDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/summary_tile/CollectionSummaryTileDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/summary_tile/ExplorationSummaryTileDirective.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/CollectionCreationService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/ExplorationCreationService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/RatingComputationService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/RatingDisplayDirective.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/domain/sidebar/SidebarStatusService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/domain/utilities/UrlInterpolationService.js"></script>
Expand Down
2 changes: 2 additions & 0 deletions core/templates/dev/head/pages/collection_editor/collection_editor.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@
<script src="{{TEMPLATE_DIR_PREFIX}}/domain/exploration/AnswerGroupObjectFactory.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/domain/summary/ExplorationSummaryBackendApiService.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/loading/LoadingDotsDirective.js"></script>

{# TODO(bhenning): Remove these once RouterServices is decoupled from the exploration editor #}
<script src="{{TEMPLATE_DIR_PREFIX}}/pages/exploration_editor/EditorServices.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/pages/exploration_editor/ExplorationEditor.js"></script>
Expand Down
4 changes: 4 additions & 0 deletions core/templates/dev/head/pages/collection_player/collection_player.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,15 @@ <h2 ng-if="collectionPlaythrough.hasFinishedCollection()" class="oppia-page-head
{{ super() }}
<script src="{{TEMPLATE_DIR_PREFIX}}/pages/collection_player/CollectionPlayer.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/pages/collection_player/CollectionNodeListDirective.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/domain/collection/CollectionNodeObjectFactory.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/domain/collection/CollectionObjectFactory.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/domain/collection/CollectionPlaythroughObjectFactory.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/domain/collection/ReadOnlyCollectionBackendApiService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/domain/collection/SkillListObjectFactory.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/attribution_guide/AttributionGuideDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/RatingComputationService.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/summary_tile/ExplorationSummaryTileDirective.js"></script>
{% endblock footer_js %}
1 change: 1 addition & 0 deletions core/templates/dev/head/pages/dashboard/dashboard.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ <h2 class="activity-title protractor-test-exp-summary-tile-title">

{% block footer_js %}
{{ super() }}
<script src="{{TEMPLATE_DIR_PREFIX}}/components/RatingComputationService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/embed_modal/ExplorationEmbedButtonService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/share/SharingLinksDirective.js"></script>

Expand Down
21 changes: 21 additions & 0 deletions core/templates/dev/head/pages/exploration_editor/exploration_editor.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,27 @@
<script>
{{ value_generators_js }}
</script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedBoolEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedChoicesEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedCustomEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedDictEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedExpressionEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedFloatEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedHtmlEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedIntEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedListEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedUnicodeEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedCustomViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedDictViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedHtmlViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedListViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedPrimitiveViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedUnicodeViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedViewerDirective.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/loading/LoadingDotsDirective.js"></script>


<script src="{{ASSET_DIR_PREFIX}}/extensions/objects/templates/BooleanEditor.js"></script>
<script src="{{ASSET_DIR_PREFIX}}/extensions/objects/templates/CodeStringEditor.js"></script>
Expand Down
25 changes: 25 additions & 0 deletions core/templates/dev/head/pages/exploration_player/exploration_player.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,31 @@ <h3>Suggest a Change</h3>

<script src="{{TEMPLATE_DIR_PREFIX}}/expressions/expressionInterpolationService.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedBoolEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedChoicesEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedCustomEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedDictEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedExpressionEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedFloatEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedHtmlEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedIntEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedListEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_editors/SchemaBasedUnicodeEditorDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedCustomViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedDictViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedHtmlViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedListViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedPrimitiveViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedUnicodeViewerDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/forms/schema_viewers/SchemaBasedViewerDirective.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/loading/LoadingDotsDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/RatingComputationService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/RatingDisplayDirective.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/summary_tile/ExplorationSummaryTileDirective.js"></script>

{{ interaction_templates }}
{{ gadget_templates }}
{% endblock footer_js %}
4 changes: 3 additions & 1 deletion core/templates/dev/head/pages/library/library.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,13 @@ <h2 ng-class="{'active': activeGroupIndex === $index}" class="oppia-library-grou

{% block footer_js %}
{{ super() }}
<script src="{{TEMPLATE_DIR_PREFIX}}/components/RatingComputationService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/profile_link/ProfileLinkImageDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/summary_tile/ExplorationSummaryTileDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/loading/LoadingDotsDirective.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/pages/library/Library.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/pages/library/LibraryFooter.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/pages/library/ActivityTilesInfinityGridDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/pages/library/SearchBarDirective.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/pages/library/SearchResultsDirective.js"></script>
Expand Down
3 changes: 3 additions & 0 deletions core/templates/dev/head/pages/profile/profile.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -158,4 +158,7 @@ <h2 class="oppia-profile-username-small-screen">
{% block footer_js %}
{{ super() }}
<script src="{{TEMPLATE_DIR_PREFIX}}/pages/profile/Profile.js"></script>

<script src="{{TEMPLATE_DIR_PREFIX}}/components/RatingComputationService.js"></script>
<script src="{{TEMPLATE_DIR_PREFIX}}/components/summary_tile/ExplorationSummaryTileDirective.js"></script>
{% endblock footer_js %}

0 comments on commit 0b155cb

Please sign in to comment.