Skip to content

Commit

Permalink
Updated changelog, flag name and podspec files
Browse files Browse the repository at this point in the history
  • Loading branch information
ijunaid committed Sep 6, 2024
1 parent 7003537 commit 884d831
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 10 deletions.
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
* Automatic view pause/resumes are changed with stop/start for better data consistency.
* Added the config interface 'experimental' to group experimental features.
* Added support for including the previous event name when recording custom events.
* Added a flag (enableViewNameRecording) to add view names to each event. (Experimental!)
* Added a flag (enableVisibilityTracking) to add app visibility info to views * Added Content feature methods:
* Added a flag (enablePreviousNameRecording) to add previous event and view names as segmentation. (Experimental!)
* Added a flag (enableVisibilityTracking) to add app visibility info to views
* Added Content feature methods:
- enterContentZone, to start Content checks(Experimental!)
- exitContentZone, to stop content checks (Experimental!)

Expand Down
2 changes: 1 addition & 1 deletion Countly-PL.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Pod::Spec.new do |s|

s.subspec 'Core' do |core|
core.source_files = '*.{h,m}'
core.public_header_files = 'Countly.h', 'CountlyUserDetails.h', 'CountlyConfig.h', 'CountlyFeedbackWidget.h', 'CountlyRCData.h', 'CountlyRemoteConfig.h', 'CountlyViewTracking.h', 'CountlyExperimentInformation.h', 'CountlyAPMConfig.h', 'CountlySDKLimitsConfig.h', 'Resettable.h', "CountlyCrashesConfig.h", "CountlyCrashData.h"
core.public_header_files = 'Countly.h', 'CountlyUserDetails.h', 'CountlyConfig.h', 'CountlyFeedbackWidget.h', 'CountlyRCData.h', 'CountlyRemoteConfig.h', 'CountlyViewTracking.h', 'CountlyExperimentInformation.h', 'CountlyAPMConfig.h', 'CountlySDKLimitsConfig.h', 'Resettable.h', "CountlyCrashesConfig.h", "CountlyCrashData.h", "CountlyContentBuilder.h", "CountlyExperimentalConfig.h"
core.preserve_path = 'countly_dsym_uploader.sh'
core.ios.frameworks = ['Foundation', 'UIKit', 'UserNotifications', 'CoreLocation', 'WebKit', 'CoreTelephony', 'WatchConnectivity']
end
Expand Down
6 changes: 3 additions & 3 deletions Countly.m
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,8 @@ - (void)startWithConfig:(CountlyConfig *)config
}
#endif

if(config.experimental.enableViewNameRecording) {
CountlyViewTrackingInternal.sharedInstance.enableViewNameRecording = YES;
if(config.experimental.enablePreviousNameRecording) {
CountlyViewTrackingInternal.sharedInstance.enablePreviousNameRecording = YES;
}
if(config.experimental.enableVisibiltyTracking) {
CountlyCommon.sharedInstance.enableVisibiltyTracking = YES;
Expand Down Expand Up @@ -930,7 +930,7 @@ - (void)recordEvent:(NSString *)key segmentation:(NSDictionary *)segmentation co

- (NSDictionary*) processSegmentation:(NSMutableDictionary *) segmentation eventKey:(NSString *)eventKey
{
if(CountlyViewTrackingInternal.sharedInstance.enableViewNameRecording) {
if(CountlyViewTrackingInternal.sharedInstance.enablePreviousNameRecording) {
if([eventKey isEqualToString:kCountlyReservedEventView]) {
segmentation[kCountlyPreviousView] = CountlyViewTrackingInternal.sharedInstance.previousViewName ?: @"";
}
Expand Down
2 changes: 1 addition & 1 deletion Countly.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Pod::Spec.new do |s|

s.subspec 'Core' do |core|
core.source_files = '*.{h,m}'
core.public_header_files = 'Countly.h', 'CountlyUserDetails.h', 'CountlyConfig.h', 'CountlyFeedbackWidget.h', 'CountlyRCData.h', 'CountlyRemoteConfig.h', 'CountlyViewTracking.h', 'CountlyExperimentInformation.h', 'CountlyAPMConfig.h', 'CountlySDKLimitsConfig.h', 'Resettable.h', "CountlyCrashesConfig.h", "CountlyCrashData.h"
core.public_header_files = 'Countly.h', 'CountlyUserDetails.h', 'CountlyConfig.h', 'CountlyFeedbackWidget.h', 'CountlyRCData.h', 'CountlyRemoteConfig.h', 'CountlyViewTracking.h', 'CountlyExperimentInformation.h', 'CountlyAPMConfig.h', 'CountlySDKLimitsConfig.h', 'Resettable.h', "CountlyCrashesConfig.h", "CountlyCrashData.h", "CountlyContentBuilder.h", "CountlyExperimentalConfig.h"
core.preserve_path = 'countly_dsym_uploader.sh'
core.ios.frameworks = ['Foundation', 'UIKit', 'UserNotifications', 'CoreLocation', 'WebKit', 'CoreTelephony', 'WatchConnectivity']
end
Expand Down
2 changes: 1 addition & 1 deletion CountlyExperimentalConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ extern NSString* const kCountlySCKeySC;

@interface CountlyExperimentalConfig : NSObject

@property (nonatomic) BOOL enableViewNameRecording;
@property (nonatomic) BOOL enablePreviousNameRecording;
@property (nonatomic) BOOL enableVisibiltyTracking;

@end
2 changes: 1 addition & 1 deletion CountlyExperimentalConfig.m
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ - (instancetype)init
if (self = [super init])
{
self.enableVisibiltyTracking = NO;
self.enableViewNameRecording = NO;
self.enablePreviousNameRecording = NO;
}

return self;
Expand Down
2 changes: 1 addition & 1 deletion CountlyViewTrackingInternal.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ extern NSString* const kCountlyPreviousEventName;
@property (nonatomic) NSString* currentViewID;
@property (nonatomic) NSString* previousViewID;

@property (nonatomic) BOOL enableViewNameRecording;
@property (nonatomic) BOOL enablePreviousNameRecording;
//TODO: Need discussion for its usage and then we decide to keep it or remove it
@property (nonatomic) NSString* currentViewName;
@property (nonatomic) NSString* previousViewName;
Expand Down

0 comments on commit 884d831

Please sign in to comment.