Skip to content

Commit

Permalink
Add deprecation for positionalParams specification
Browse files Browse the repository at this point in the history
As part of emberjs#2256
  • Loading branch information
romulomachado committed Oct 9, 2015
1 parent 02826d6 commit 142393a
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions source/deprecations/v1.x.html.md
Original file line number Diff line number Diff line change
Expand Up @@ -911,6 +911,32 @@ export default Ember.Controller.extend({

You can [view and manipulate this example on jsbin](http://emberjs.jsbin.com/qegikoliri/1/edit?html,js,output)

#### Set `positionalParams` as a static property on the class

Setting `positionalParams` within `.extend` is deprecated. It has to be set as a static property on the class itself (`.reopenClass`).

Plaease change this:

```javascript
import Ember from 'ember';

export default Ember.Component.extend({
positionalParams: [ 'a', 'b' ]
});
```

to this:

```javascript
import Ember from 'ember';

var Thing = Ember.Component.extend();
Thing.reopenClass({
positionalParams: [ 'a', 'b' ]
});

```

#### Ember.ReduceComputed / Ember.ArrayComputed

This two little monsters served us well for a long time. They provided semantics that allowed to
Expand Down

0 comments on commit 142393a

Please sign in to comment.