Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stemmer_cpp.pyx): implementation of the .pyx that bridges the C++ code to Python calls #44

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

pedrobiqua
Copy link
Collaborator

Pull Request

Checklist

Please ensure that your PR fulfills the following requirements:

  • [] Unit tests have been added or updated for the changes (for bugfixes or new features).
  • Code compiles without warnings or errors.
  • All new and existing tests pass locally.
  • Code follows the project's C++ style guidelines (e.g., naming conventions, indentation).
  • Documentation has been updated where applicable (e.g., function headers, inline comments).

PR Type

What type of change does this PR introduce?

  • Bugfix
  • New feature
  • Performance improvement
  • Code style update (formatting, naming conventions)
  • Refactoring (no functional or API changes)
  • Build or configuration changes
  • CI-related changes
  • Documentation updates
  • Other (please describe):

What is the current behavior?

Issue Number: fix #42

What is the new behavior?

Now it will be possible to perform preprocessing on the data, extracting only the root of sentences in Portuguese, as shown in this example:

from search_engine_cpp.preprocessing.stemmer_cpp import PyRSPL

rspl = PyRSPL()
text = "O coração bate rapidamente na cidade"
result = rspl.run(text)
print(result)

Does this PR introduce a breaking change?

  • Yes
  • No

Testing Details

All passed.

Additional Information

No additional information provided.

@pedrobiqua pedrobiqua added enhancement New feature or request C++ labels Jan 20, 2025
@pedrobiqua pedrobiqua merged commit 60b1a38 into main Jan 20, 2025
3 checks passed
@pedrobiqua pedrobiqua deleted the 42-feat/cython-bind-for-rspl-algorithm branch January 20, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Implement Cython Binding for C++ Preprocessing Algorithm
1 participant