fixed parsing of empty names with multiple $ORIGINS #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an $ORIGIN is defined that is different from the zone name, then records with "empty names" (which refer to the previous record) are not correctly parsed.
Example input for zone "mydomain.biz.":
The second entry is parsed as "._subdomain.mydomain.biz." instead of "test._subdomain.mydomain.biz.".
I think the best fix is to check for empty name in
appendOrigin()
, so it is correctly handled bypopulateNullValues()
later (as it is already handled if we are in main zone context).This PR implements the fix with the corresponding test.