Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed parsing of empty names with multiple $ORIGINS #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

not-implemented
Copy link

When an $ORIGIN is defined that is different from the zone name, then records with "empty names" (which refer to the previous record) are not correctly parsed.

Example input for zone "mydomain.biz.":

$ORIGIN _subdomain.mydomain.biz.

test A 192.168.2.42
     A 192.168.2.43

The second entry is parsed as "._subdomain.mydomain.biz." instead of "test._subdomain.mydomain.biz.".

I think the best fix is to check for empty name in appendOrigin(), so it is correctly handled by populateNullValues() later (as it is already handled if we are in main zone context).

This PR implements the fix with the corresponding test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant