Added support for empty salt ( aka dash ) #120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using \Badcow\DNS\Parser\Parser::parse, and the zone file contains and empty salt in the NSEC3PARAM, it throws an error:
This is because the setSalt function in Rdata/NSEC3PARAM.php is as follows:
This is a problem, because the salt can be empty ( dash ) but this is not support in this function.
Adding a simple check to see if its a dash, and just return, resolves this issue.
I dont know if you guys want it written differently, let me know.
This is also a issue in getSalt and fromWire