Rule out test assemblies from versioning test sets #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now handled via a hard-coded list of assembly names. Happy for this to be changed to something smarter. Open for ideas @adecler @pawelbaran
|
@adecler after doing this I had another thought. Could potentially make use of the |
pawelbaran
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Makes sense in general, just one thought for an alternative: filtering by assembly method that would take:
- a collection of types/methods
- a collection of strings correspondent to assembly names
- bool ignore vs include
...could be helpful in other places as well. But just a thought, please feel free to ignore 😉
| /**** Private Fields ****/ | ||
| /***************************************************/ | ||
|
|
||
| private static HashSet<string> m_testToolkitAssemblyNames = new HashSet<string> { "CodeComplianceTest_Engine", "CodeComplianceTest_oM", "InteroperabilityTest_Engine", "InteroperabilityTest_oM", "NUnit_Engine", "NUnit_oM", "Test_Engine", "TestRunner", "UnitTest_Engine", "UnitTest_oM" }; |
There was a problem hiding this comment.
I would consider splitting the collection with line breaks for readability
Start of milestone changes for 8.1
These method are to following BHoM Compliance and have either been added to handle Different versions of revit, or should be removed. Either way, these methods should not be part of the general versioning
…nput to allow for ruling out specific adapter types
…enericImmutableDummyObjects Correctly set concrete generic type for immutable objects
…OrderReducedToWarning Reduce status from error to warning for attributes in order check
…omVersioningTestSets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #486
Explicitly rule out any type or method from a Test_Toolkit assembly from being included in test sets.
Test files
Ensure no test_Toolkit method is part of the included methods/types
GenerateLegacyDataset.zip
Changelog
Additional comments