X11 clipboard incr proto #12357
X11 clipboard incr proto #12357
Conversation
… byte in prop_return)
(CLIPBOARD_MANAGER has a hardcoded size = 0x40000) This reverts commit 59b0b24.
|
You can test this PR using the following package version. |
|
What would happen if two operations overlap? e. g. if avalonia app tries to paste twice in a row or if it receives data requests from 2 applications (one being a clipboard manager reacting to changed selection, another one initiated by the app the user alt-tabbed into). It is quite possible for one of those to not be completed yet when the second one begins, since transferring 64mb of an 4K image can take a bit of time. The initial plan for supporting INCR was to refactor the code in a way that would track each operation in an instance of a special class. |
do you want to make support for parallel work with the clipboard? Or is blocking enough at the time of writing/reading fragmented data |
|
Blocking won't really help since an unrelated event might arrive and we can't really ignore those |
|
with the last 2 commits I added support for parallel operations INCR. ps. without knowing the rules of the project code, new classes were created inside the X11 clipboard class |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
What does the pull request do?
improving the functionality of the X11 clipboard::
What is the current behavior?
The INCR protocol is not implemented. (https://x.org/releases/X11R7.6/doc/xorg-docs/specs/ICCCM/icccm.html#id2588019)
What is the updated/expected behavior with this PR?
Ability to copy/paste data larger than 256 KB
How was the solution implemented (if it's not obvious)?
Sending/receiving data in chunks of 256 k bytes.
Using the XExtendedMaxRequestSize/XMaxRequestSize methods to get the fragment size supported by the system was unsuccessful because CLIPBOARD_MANAGER has a hard-coded value of 256 KB (Linux Ubuntu 18/22 and Mint 21.1 Mate)
Testing was performed via the Clipboard Page in samples/Control Catalog(together with the image from the clipboard PR #12246)