Revert "Only enable RegionFX in debug builds for the time being"

This reverts commit d525f8d.
Ardour · Oct 17, 2024 · 0986b8d · 0986b8d
1 parent b6cb758
commit 0986b8d
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 8 deletions.
diff --git a/gtk2_ardour/audio_region_editor.cc b/gtk2_ardour/audio_region_editor.cc
@@ -98,15 +98,13 @@ AudioRegionEditor::AudioRegionEditor (Session* s, AudioRegionView* arv)
 	_table.attach (_fade_before_fx_toggle, 2, 3, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL);
 	++_table_row;
 
-#ifndef NDEBUG  // disable region Fx for now
 	_region_line_label.set_name ("AudioRegionEditorLabel");
 	_region_line_label.set_text (_("Region Line:"));
 	_region_line_label.set_alignment (1, 0.5);
 	_table.attach (_region_line_label, 0, 1, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL);
 	_table.attach (_region_line, 1, 2, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL);
 	_table.attach (_show_on_touch, 2, 3, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL);
 	++_table_row;
-#endif
 
 	UI::instance()->set_tip (_polarity_toggle, _("Invert the signal polarity (180deg phase shift)"));
 	UI::instance()->set_tip (_fade_before_fx_toggle, _("Apply region effects after the region fade.\nThis is useful if the effect(s) have tail, which would otherwise be faded out by the region fade (e.g. reverb, delay)"));

diff --git a/gtk2_ardour/region_editor.cc b/gtk2_ardour/region_editor.cc
@@ -187,10 +187,8 @@ RegionEditor::RegionEditor (Session* s, RegionView* rv)
 	_table.attach (_sources, 1, 2, _table_row, _table_row + 1, Gtk::FILL | Gtk::EXPAND, Gtk::FILL);
 	++_table_row;
 
-#ifndef NDEBUG // disable region FX for now
 	_table.attach (region_fx_label, 2, 3, 0, 1, Gtk::FILL, Gtk::FILL);
 	_table.attach (_region_fx_box,  2, 3, 1, _table_row + 2, Gtk::FILL, Gtk::FILL);
-#endif
 
 	get_vbox()->pack_start (_table, true, true);
 
@@ -232,13 +230,11 @@ RegionEditor::RegionEditor (Session* s, RegionView* rv)
 
 	spin_arrow_grab = false;
 
-#ifndef NDEBUG // disable region FX for now
 	/* for now only audio region effects are supported */
 	if (std::dynamic_pointer_cast<AudioRegion> (_region)) {
 		region_fx_label.show ();
 		_region_fx_box.show ();
 	}
-#endif
 
 	connect_editor_events ();
 }

diff --git a/libs/ardour/luabindings.cc b/libs/ardour/luabindings.cc
@@ -1654,12 +1654,10 @@ LuaBindings::common (lua_State* L)
 		.addFunction ("has_transients", &Region::has_transients)
 		.addFunction ("transients", (AnalysisFeatureList (Region::*)())&Region::transients)
 
-#ifndef NDEBUG // disable region FX for now
 		.addFunction ("load_plugin", &Region::load_plugin)
 		.addFunction ("add_plugin", &Region::add_plugin)
 		.addFunction ("remove_plugin", &Region::add_plugin)
 		.addFunction ("nth_plugin", &Region::nth_plugin)
-#endif
 
 		/* editing operations */
 		.addFunction ("set_length", &Region::set_length)