added stop to carbon ph calculation if not converging #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in rare cases the calculation of pH using the Newton method does not converge, thus hanging the program. I added a catch for this - though it might be useful to also add a message that provided if the pH calculation takes too many iterations. I am not sure why it isn't converging because I don't understand the pH calculations well enough. I am happy to share the files necessary to recreate the issue if helpful.