Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stop to carbon ph calculation if not converging #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rqthomas
Copy link
Contributor

@rqthomas rqthomas commented Oct 3, 2019

I found that in rare cases the calculation of pH using the Newton method does not converge, thus hanging the program. I added a catch for this - though it might be useful to also add a message that provided if the pH calculation takes too many iterations. I am not sure why it isn't converging because I don't understand the pH calculations well enough. I am happy to share the files necessary to recreate the issue if helpful.

@rqthomas rqthomas changed the title added stop to carbon ph calculation if nnot converging added stop to carbon ph calculation if not converging Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant