Opened 14 years ago
Closed 14 years ago
#6332 closed Bug (fixed)
IE: V2 skin bottom dialog's border broken
| Reported by: | Tobiasz Cudnik | Owned by: | Paweł Horzela |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.2 |
| Component: | UI : Dialogs | Version: | 3.4 |
| Keywords: | IE | Cc: |
Description
V2 skin bottom dialog's border is broken in IE since version 3.4. It was fine in 3.4 Beta and 3.3.2.
Refer to attached screenshot. Reproduced on IE8 standards mode.
Attachments (4)
Change History (18)
Changed 14 years ago by
| Attachment: | 2010-09-21-123724_490x499_scrot.png added |
|---|
comment:1 Changed 14 years ago by
| Milestone: | → CKEditor 3.4.2 |
|---|---|
| Status: | new → confirmed |
comment:2 Changed 14 years ago by
| Owner: | set to Paweł Horzela |
|---|---|
| Status: | confirmed → assigned |
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
'change' event is not fired because of 'noChangeEvent' flag that is always set to 'true'.
comment:5 Changed 14 years ago by
Regression connected with ticket #6137: http://dev.ckeditor.com/ticket/6137
comment:6 Changed 14 years ago by
Because 'change' event is not fired, body.$.offsetHeight of dialog window is not recalculated and the vertical borders are too long. We must expand the content of the dialog window to be as long as borders.
comment:7 Changed 14 years ago by
| Status: | assigned → review |
|---|
comment:8 Changed 14 years ago by
| Status: | review → review_failed |
|---|
I've seen similar things happen randomly also in office2003. A more generic solution could be found.
comment:9 Changed 14 years ago by
comment:10 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:11 Changed 14 years ago by
| Status: | review → review_failed |
|---|
We didn't take your proposed approach earlier because we concluded that it's more than just this specific field. We'll face the same problem everytime we use this event, i.e. when there is a default height set in this dialog.
comment:12 Changed 14 years ago by
| Status: | review_failed → review |
|---|
comment:13 Changed 14 years ago by
| Status: | review → review_passed |
|---|
comment:14 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [5945]
Regresion introduced in revision 5840: http://dev.ckeditor.com/changeset/5840