Opened 15 years ago
Closed 15 years ago
#4993 closed Bug (fixed)
Cannot change image alignment back to "not set" without reopening a dialog
| Reported by: | Wiktor Walc | Owned by: | Minh Nguyen |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.2 |
| Component: | General | Version: | 3.0.2 |
| Keywords: | Confirmed Review+ | Cc: |
Description
When embedding an image, if you change the alignment dropdown to either left or right, you can't change it back to "<not set>" without reopening the dialog.
Steps to reproduce
- Start with
<h1> <img alt="" src="http://a.cksource.com/c/1/inc/img/fireworks.png" />Happy New Year!</h1> <p> The CKSource team wishes a <strong>wonderful and happy New Year</strong> to everybody around the globe!</p>
- open image dialog, change alignment to right, change alignment to
<not set> - result:
<img alt="" src="http://a.cksource.com/c/1/inc/img/fireworks.png" style="float: right;" />
(float: right has not been removed).
Attachments (1)
Change History (5)
Changed 15 years ago by
| Attachment: | 4993.patch added |
|---|
comment:1 Changed 15 years ago by
| Keywords: | Review? added |
|---|---|
| Owner: | set to Minh Nguyen |
| Status: | new → assigned |
comment:2 Changed 15 years ago by
comment:3 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
That's true, we don't need to retain float values that are not supported.
Note: See
TracTickets for help on using
tickets.
In this case we don't need using method this.isChanged() in condition.