Opened 15 years ago
Closed 15 years ago
#4522 closed Bug (fixed)
[IE] Unable to redo on inserted element + typing
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | Core : Undo & Redo | Version: | SVN (CKEditor) - OLD |
| Keywords: | IE Review+ | Cc: |
Description
Environments
IE6/IE7 (IE8 works well)
Procedures
- Focus the editor;
- Open the 'Smiley' dialog and insert an icon;
- Start typing a few words;
- Press 'Undo' button or 'Ctrl-Z' key;
- Actual Result: Typed words are removed;
- Press 'Undo' button or 'Ctrl-Z' key again;
- Expected Result: Icon is removed.
- Actual Result: Unable to remove the icon, even 'Undo' button is enable there.
Attachments (3)
Change History (10)
Changed 15 years ago by
| Attachment: | 4522.patch added |
|---|
comment:1 Changed 15 years ago by
| Keywords: | Review? added |
|---|---|
| Owner: | set to Garry Yao |
| Status: | new → assigned |
comment:2 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Changed 15 years ago by
| Attachment: | 4522_2.patch added |
|---|
comment:3 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|---|
| Version: | → SVN (CKEditor) |
@fredck You're using IE8 quirks mode for testing and the above patch has wrong detection.
It's even safer to target the fix to all browsers.
comment:4 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
We should not make this fix viral, impacting on the performance of good browsers. Let's limit this fix to IE only, using CKEDITOR.env.ie8Compat to avoid it into IE8 also (as long as it's really true that IE8 is ok with it).
Changed 15 years ago by
| Attachment: | 4522_3.patch added |
|---|
comment:5 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:6 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Note: See
TracTickets for help on using
tickets.
I don't see any difference after the patch.