Page MenuHomePhabricator
Differential D215116

Bug 1878510 - When recreating WebM demuxer when encountering a new segment, propagate media time (esr115 rebase)
Needs ReviewPublic
Actions

Authored by padenot on Jun 27 2024, 2:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 27 2024, 7:22 PM
Unknown Object (File)
Jun 27 2024, 7:22 PM
Subscribers
alwu
reviewbot
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Commits
rMOZILLACENTRALfec193c3620a: Bug 1878510 - When recreating WebM demuxer when encountering a new segment…
Bugzilla Bug ID
1878510

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

padenot created this revision.Jun 27 2024, 2:47 PM
Herald added a project: secure-revision. · View Herald TranscriptJun 27 2024, 2:47 PM
Harbormaster completed remote builds in B677374: Diff 883188.Jun 27 2024, 2:47 PM
phab-bot published this revision for review.Jun 27 2024, 2:48 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: media-playback-reviewers. · View Herald TranscriptJun 27 2024, 2:48 PM
reviewbot added a subscriber: reviewbot.Jun 27 2024, 4:56 PM

Code analysis found 1 defect in diff 883188:

  • 1 build error found by clang-tidy
IMPORTANT: Found 1 defect (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 883188.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2024, 6:18 PM
Closed by commit rMOZILLACENTRALfec193c3620a: Bug 1878510 - When recreating WebM demuxer when encountering a new segment… (authored by alwu). · Explain Why
This revision was automatically updated to reflect the committed changes.
alwu added a commit: rMOZILLACENTRALfec193c3620a: Bug 1878510 - When recreating WebM demuxer when encountering a new segment….
sstanca reopened this revision.Jun 27 2024, 6:55 PM
sstanca added a reverting change: rMOZILLACENTRALd80101c05354: Backed out 3 changesets (bug 1878510, bug 1900191, bug 1904168) for causing….
alwu added a subscriber: alwu.Jun 27 2024, 7:30 PM

Fix build error in D215156. We will discard this patch.

alwu removed a reviewer: media-playback-reviewers.Jun 27 2024, 7:30 PM

Revision Contents
Changeset List

PathSize
dom/
media/
mediasource/
2 lines
42 lines
webm/
6 lines
21 lines

Diff 883329

View Options

dom/media/mediasource/TrackBuffersManager.h

Loading...
View Options

dom/media/mediasource/TrackBuffersManager.cpp

Loading...
View Options

dom/media/webm/WebMDemuxer.h

Loading...
View Options

dom/media/webm/WebMDemuxer.cpp

Loading...
Privacy · Cookies · Legal