Code analysis found 13 defects in the diff 408002:

• 13 build errors found by clang-tidy

You can run this analysis locally with:

• ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 408002, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Oh, we'll also probably want to remove the hung plugin / terminate plugin code from ProcessHangMonitor.jsm in a follow-up, unless we still need that stuff for GMP processes.

Derp. CrashReporter, HangMonitor... at least I was in the vicinity :-P. Fixed the comment to match the patch.
I'll need to do a little homework to clear the rest of ProcessHangMonitor -- I'm not clear on the GMP distinction either. I'll file a bug.

Code analysis found 13 defects in the diff 414009:

• 13 build errors found by clang-tidy

You can run this analysis locally with:

• ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 414009, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 15 defects in the diff 421890:

• 13 build errors found by clang-tidy
• 2 defects found by private static analysis

You can run this analysis locally with:

• For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
• ./mach static-analysis check --outgoing (C/C++)

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 421890, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 3 defects in the diff 422929:

• 1 build error found by clang-tidy
• 2 defects found by private static analysis

You can run this analysis locally with:

• For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
• ./mach static-analysis check --outgoing (C/C++)

You have touched the documentation in diff 422929, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 3 defects in the diff 423040:

• 1 build error found by clang-tidy
• 2 defects found by private static analysis

You can run this analysis locally with:

• For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
• ./mach static-analysis check --outgoing (C/C++)

You have touched the documentation in diff 423040, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.